On Tue, Oct 29, 2013 at 9:00 PM, Benjamin Poulain <benja...@webkit.org> wrote: > Hi WebKit,
Hi, > I plan to remove the code guarded by LEGACY_VIEWPORT_ADAPTION and the flag > itself. I was reading the original bug report[1] to find a list of websites targeting mobile devices that don't render well if this feature is disabled, the original list includes: m.yahoo.com m.google.com m.facebook.com All this if you do not use some apple-like user agent, I did test them again today to check the current status and just m.google.com is still using those legacy DTD causing WebKit to render the page into a 980px canvas where it was designed to be rendered into a 320px canvas. There may be other (old) sites not rendering well but at least at the time of the bug report this small list with very popular websites was enough to add this feature to a product (N9 phone) then to WebCore. I also found that besides Blackberry, Chromium turned on this flag[2] last year, but I didn't check if it still enabled on blink. Support legacy stuff is a pain and just inject undesirable code in the codebase, but I would like to know if there are other options rather than just removing the feature and let few, but some important, website not working? [1] https://bugs.webkit.org/show_bug.cgi?id=85425 [2] https://bugs.webkit.org/show_bug.cgi?id=90991 Regards, Hugo > The reason is: this code is mostly incorrect and leads to valid viewport > configurations only with the most trival cases. > > It seems to be only enabled by Nix and Blackberry but I can't tell if it is > intentional. > > Benjamin > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
