On Feb 11, 2014, at 12:29 AM, Žan Doberšek <zandober...@gmail.com> wrote:
> Hi. > > On Mon, Feb 10, 2014 at 6:30 PM, Dan Bernstein <m...@apple.com> wrote: > Hi everyone, and especially EFL and GTK contributors! > > In preparation for changing PLATFORM(MAC) to be false when building for iOS, > I have been reviewing usage of PLATFORM(MAC) throughout our codebase. Some of > these uses are really about targeting the Darwin OS. However, I could not > simply replace PLATFORM(MAC) with OS(DARWIN), because the latter also > encompasses the EFL and GTK platforms when building for Darwin (which the > former does not). Therefore, thus far I have replaced relevant instances of > PLATFORM(MAC) with (OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK)). > > Just to be clear, this is about code that's not appropriate to guard with > PLATFORM(COCOA)? Yup. > > > This is ugly and seems like a waste of time, so I was wondering: > > 1. Is there a configuration of the EFL port that actually builds for Darwin? > > 2. Is there a configuration of the GTK port that actually builds for Darwin? > > Yes, this configuration is supported by the GTK port through the MacPorts > project. Jeremy Huddleston regularly upstreams modifications to properly > support building the GTK port on Darwin. > > > 3. If such configuration(s) exist, would it be OK for them to use Darwin when > building for Darwin? > > This could be possible, but it depends really on the code in question. Jeremy > would probably be the best candidate to exactly tell you whether the new code > is viable to use for the GTK port on Darwin. > > > If the answer to 1 and 2 is no, or if the answer to 3 is yes, then I will > simply use OS(DARWIN) to replace PLATFORM(MAC) where that is the intent, and, > depending on the answers to 1 and 2, update the EFL and GTK build systems to > include the Darwin-based implementations where needed. > > Thanks! > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
