On 03/12/2014 05:34 PM, Alexey Proskuryakov wrote:
11 марта 2014 г., в 10:43, Filip Pizlo <[email protected]
<mailto:[email protected]>> написал(а):
Any particular reason for removing the list of changed files? I find
that to be the easiest way of determining, at a glance, what kind of
an effect a change has. If rollouts no longer include this list then
I will have to click the trac links for all of the reverted changes to
figure out that file list. Seems painful.
Hopefully, having a title of the rolled out bug will provide the same
information in a more concise way, without adding noise to ChangeLogs.
I'm not sure if the new behavior preserves file lists when the patch
being rolled out isn't associated with a bug.
Trac and webkit-changes mails still contain the file list, doesn't
matter if there was or wasn't bug report for the rolled out changes.
But unfortunately the description will be missing if there wasn't
bug report for the original change, because the description parser [1]
is too conservative. It recognizes the description only if the 4th line
of the changelog entry is bug url. Maybe we should make it smarter with
some heuristics or simple we should suppose that the 3rd line is the
description always. There aren't so much malformed changelog entry.
I filed a new bug report for improving description parser:
https://bugs.webkit.org/show_bug.cgi?id=130137
br,
Ossy
[1]
https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py?rev=165447#L190
_______________________________________________
webkit-dev mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-dev
