(re-sent from correct address)
11 июля 2014 г., в 3:59, Maciej Stachowiak <[email protected]> написал(а):
> So it seems like the extra request for people using “webkitbot rollout” is to
> add diagnostic information to the rollout bug, and wait a reasonable period
> before cq+ing it. Is that something everyone could live with?
In the past, I've seen people overlook comments in rollout bugs more frequently
than in original bugs, so I usually added the diagnostic information to the
original bug. I think that it's more relevant there, as that's where people
will be continuing the work. Knowing what the failure symptoms were is
certainly relevant when reviewing a new iteration of the patch.
I have a potential issue with "reasonable period". In the thread, someone
mentioned "~3 hours" as the time to wait. But having brokenness for a good part
of a business day is unhelpful even if it's only one thing that's broken at a
given time. Regressions are introduced more frequently than one per three hours
on average, so a grace period this long will result in never having green tests
(here I assume that no one advocates for any sort of grace period for build
failures).
My strong preference is immediate reaction. It doesn't always have to be a
rollout, sometimes an issue can be fixed, or some tests can even be temporarily
skipped - just make the tree green and stable for everyone else, as quickly as
possible. But if the author is not available, and the bot watcher doesn't have
a better fix (or is simply overwhelmed with multiple regressions being under
investigation at once), I think that immediate rollout should be considered
normal.
- Alexey
_______________________________________________
webkit-dev mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-dev
