Hi Said, Can you please resubmit your patch? The EWS build directory was cleaned-up.
Philippe On Fri, 2014-10-31 at 09:55 -0700, Said Abou-Hallawa wrote: > I submitted a patch for the bug https://bugs.webkit.org/show_bug.cgi?id=137132 > The build failed for gtk-wk2 but passed for mac and mac-wk2. Here is the > failure. > > Last 500 characters of output: > e/CMakeFiles/WebCore.dir/rendering/style/RenderStyle.cpp.o -c > ../../Source/WebCore/rendering/style/RenderStyle.cpp > ../../Source/WebCore/rendering/style/RenderStyle.cpp: In member function > 'WebCore::Color WebCore::RenderStyle::colorIncludingFallback(int, bool) > const': > ../../Source/WebCore/rendering/style/RenderStyle.cpp:1525:10: error: > 'CSSPropertyWebkitColumnRuleColor' was not declared in this scope > case CSSPropertyWebkitColumnRuleColor: > > > In the patch I have the following change > > > Source/WebCore/rendering/style/RenderStyle.cpp > @@Color RenderStyle::colorIncludingFallbac > 15221522 case CSSPropertyOutlineColor: > 15231523 result = visitedLink ? visitedLinkOutlineColor() : > outlineColor(); > 15241524 break; > > 1525 case CSSPropertyWebkitColumnRuleColor: > 1525 case CSSPropertyColumnRuleColor: > > 15261526 result = visitedLink ? visitedLinkColumnRuleColor() : > columnRuleColor(); > 15271527 break; > 15281528 case CSSPropertyWebkitTextDecorationColor: > > > > > I am un-prefixing the column rule color property. So I replaced > CSSPropertyWebkitColumnRuleColor with CSSPropertyColumnRuleColor. But > the failure is saying the prefixed property is not defined. > > > How can for gtk-wk2 only, the patch is not applied in RenderStyle.cpp > but is applied with other files and is applied also for all files for > the mac platform? > > > Thanks, > Said > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
