Right now, EWS restarts after every 20 iterations or so. We could expedite the process by doing it more frequently. However, I can't think of a way we can test a webkitpy patch that affects EWS on EWS since it's webkitpy code that's applying the patch and running the tests, etc…
On Thu, Apr 2, 2015 at 1:48 AM, Maciej Stachowiak <[email protected]> wrote: > You said it did not detect the failure until many builds later. That seems > bad. People expect EWS validation to happen on their bug, not out of band > 10-13 builds later. Is there any way to fix this limitation? That seems > better than asking people to remember exceptions about patches that EWS > can't validate the normal way. > > > > On Apr 1, 2015, at 9:29 PM, Brent Fulgham <[email protected]> wrote: > > The Windows EWS bots process patches fairly quickly. Once I corrected the > problem today, it managed to process about 97 patches in about an hour. > > I do think one bottleneck is due to individual EWS bots “locking” patches. > The first bot to reach a patch locks the patch against other bots handling > it. If the patch happens to be ‘consumed’ be a bot with some kind of > problem (e.g., bad local configuration, a full disk drive, etc.), that > patch will not be touched again — even if the other eight EWS bots are > sitting dormant. > > Is there some other processing metric you are concerned about? > > Brent Fulgham - Apple Inc. > > > > On Apr 1, 2015, at 2:26 PM, Maciej Stachowiak <[email protected]> wrote: > > > Is it possible to make EWS start processing changes more promptly? > > On Apr 1, 2015, at 12:42 PM, Brent Fulgham <[email protected]> wrote: > > Hi Everyone, > > We lost Windows EWS coverage for the past 36 hours due to a very > benign-appearing change to some webkitpy code. I haven’t yet figured out > why this particular set of changes caused the Windows bots to start > failing, but it has to do with various differences between the Cygwin > Python 2.7.8 build and the versions used on our other EWS bots. > > This does not seem like something developers SHOULD have to worry about, > but it’s an unfortunately reality that they really do need to. > > To make matters worse, the patch that introduced the problem passed EWS. > This is because the EWS bots only really begin using changes to webkitpy > when they restart processing (about once every 10-13 build iterations). > > To help combat this problem, I’d like to request that when making changes > to webkitpy, please keep an eye on the various EWS bots to make sure they > continue processing. If they do start failing, please roll the patch back > out and we can work together to resolve the issue. > > I apologize for how manual and inconvenient this needs to be (at least for > now), but keeping the EWS up and running is critical to the smooth function > of this project. > > If you have any questions, please don’t hesitate to e-mail me or look for > me on IRC. > > Thanks! > > -Brent > _______________________________________________ > webkit-dev mailing list > [email protected] > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > _______________________________________________ > webkit-dev mailing list > [email protected] > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > > _______________________________________________ > webkit-dev mailing list > [email protected] > https://lists.webkit.org/mailman/listinfo/webkit-dev > >
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
