👍 To make this policy easy for new folks, I agree with Ryosuke that we should extract a JS and CSS style guide that is separate from Inspector-specific concerns.
Geoff > On Jul 6, 2016, at 10:17 PM, Filip Pizlo <fpi...@apple.com> wrote: > > I like the idea of adopting inspector style for JS builtins! > > It might also be good to adopt it for JS tests that we write ourselves, with > an escape hatch if you need to violate style to test some feature. For > example, it should be a goal to follow inspector style for the JetStream > harness code, and probably for all of ES6SampleBench. New JS tests in > JavaScriptCore/tests/stress that we write ourselves probably should follow > inspector style, because it's code that we have to read and understand and I > can't think of a reason not to be consistent. Thoughts? > > -Filip > >> On Jul 6, 2016, at 7:53 PM, Ryosuke Niwa <rn...@webkit.org> wrote: >> >>> On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson <d...@apple.com> wrote: >>> I propose we make it official that the Web Inspector Coding Style is what >>> must be used for all JavaScript and CSS that count as source code in the >>> project. >>> https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide >>> >>> Now that JavaScript is used in more places (JS builtins, some parts of the >>> DOM, media controls) it would be nice to make it all consistent. Note that >>> the page above can't decide if it is just JS or both JS and CSS, but I >>> think it should be both. >> >> It's hard to tell which parts of the above guide would apply to >> non-Inspector JS code because it has a bunch of Inspector specific >> guidelines such as layering guides and references to >> https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css >> >> We should probably extract the parts that matter into a separate MD >> file or a section in the wiki page before we proceed with this >> discussion. >> >> - R. Niwa >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
