I've now taken a separate approach <https://bugs.webkit.org/show_bug.cgi?id=158902>, which doesn't require changing the default in order for the IndexedDB tests to run successfully.
On Thu, Jul 7, 2016 at 11:33 AM, Yoav Weiss <y...@yoav.ws> wrote: > After encountering flakiness as a result of runtime flags leaking between > tests, I wrote a patch <https://bugs.webkit.org/show_bug.cgi?id=158902> > that resets all feature flags to their default values between tests. > > The problem I encountered was that IndexedDB was turned off by default in > RuntimeEnabledFeatures, but was (and still is) manually turned on by > WebView (on both mac and win) and by WebKit2. That meant that reseting it > to the default value between tests caused a lot of tests to fail (as they > were relying on it being on). At the same time, I'm not sure that flipping > the default to true won't have an undesired impact on other ports which may > have the feature turned off. > > So, I'd love some advice on that front. Do the other ports have that > feature disabled as I suspect? If so, would it be a problem to turn it on > for those ports? > > Thanks, > Yoav >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
