> On Aug 30, 2017, at 2:15 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 30.08.2017, 03:01, "Michael Catanzaro" <mcatanz...@igalia.com>: >> On Tue, Aug 29, 2017 at 6:20 PM, Alicia Boya García <ab...@igalia.com> >> wrote: >>> As long as the sets are generated consistently that approach should be >>> equally fine and indeed it would reduce the burden for contributors. >>> You >>> may need at least a file to write exceptions (files not to be included >>> in any bundle) though. >>> >>> -- Alicia. >> >> I agree, with the style checker to check for naming conflicts within >> the same directory, and with some help from EWS, automatic generation >> of bundles should work out fine. > > Note that EWS and webkit-patch run check-webkit-style over *diff* only, > so it won't be possible to detect such naming conflcts outside of patch > boundaries with check-webkit-style > >
To be fully effective, we'd have to have a checker script that looks at the source tree too, at least files in the same directory as any touched by the patch. - Maciej > >> >> I'm glad we've discarded the original namespace proposal. >> >> Michael >> >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > -- > Regards, > Konstantin > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
