On Thu, May 24, 2018 at 3:22 AM, Philip Jägenstedt <[email protected]> wrote:
> On Wed, May 23, 2018, 23:43 youenn fablet <[email protected]> wrote: > >> Le mer. 23 mai 2018 à 14:11, Frédéric Wang <[email protected]> a écrit : >> >>> On 23/05/2018 22:50, Ryosuke Niwa wrote: >>> > As we have preciously discussed, we should NEVER commit new tests into >>> > LayoutTests/imported/w3c/web-platform-tests. >>> >> >> Ryosuke, correct me if I am wrong, I think you are pointing out the >> following rule: >> Changes to LayoutTests/imported/w3c/web-platform-tests tests should land >> first in WPT repository, then in WebKit repository. >> > > Oh, that is surprising. > > https://github.com/w3c/web-platform-tests/pull/10964 is a recent WebKit > export, and https://trac.webkit.org/changeset/231788/webkit did modify > the test in place. Do you mean that the WPT PR was merged first, or should > be in general? Chromium and Gecko do it in the other order, and I'd be > interested to understand the trade-offs of flipping the order. > Yes, it's okay for a WebKit commit to merge the change which got merged into WPT but it's never okay to first commit the test into WebKit and then later upstream it to WPT... Any process like this where changes end up in WebKit trunk via anything > except a full WPT import will mean that divergence is possible. > Precisely to avoid these problems. > In Chromium, regular imports are the safeguard that will eventually > resolve any issuesinvolves. In practice, much to my surprise, we've really > never had something funny happen due to the temporary divergence the > process involves. > >> - R. Niwa
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
