> On Dec 6, 2018, at 4:37 PM, Ryan Haddad <[email protected]> wrote: > > Chris, > > I'm assuming that this is in reference to the patch in > https://bugs.webkit.org/show_bug.cgi?id=192373 > <https://bugs.webkit.org/show_bug.cgi?id=192373>. My guess is that something > about the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj is > causing an issue with unified sources. > > The commit-queue itself has been landing other patches without issue and the > build isn't broken on trunk bots. CC'ing Tim in case he can help point out > the issue. >
Yea must be. Any ideas why this wouldn’t build? I moved this .h/.mm to another folder (from Mac -> Cocoa) > Ryan > >> On Dec 6, 2018, at 3:55 PM, Chris Fleizach <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi >> >> Looks like Commit Queue is blocked on processing patches because of a build >> failure that's been there for a day >> >> -------------------------------------- >> https://webkit-queues.webkit.org/results/10296999 >> <https://webkit-queues.webkit.org/results/10296999> >> In file included from >> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: >> In file included from >> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:27: >> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:229:40: >> error: unknown type name 'SafeBrowsingWarning'; did you mean >> 'WKSafeBrowsingWarning'? >> void showSafeBrowsingWarning(const SafeBrowsingWarning&, >> CompletionHandler<void(Variant<ContinueUnsafeLoad, URL>&&)>&&); >> ^~~~~~~~~~~~~~~~~~~ >> WKSafeBrowsingWarning >> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:56:12: >> note: 'WKSafeBrowsingWarning' declared here >> OBJC_CLASS WKSafeBrowsingWarning; >> ^ >> In file included from >> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: >> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1619:19: >> error: out-of-line definition of 'showSafeBrowsingWarning' does not match >> any declaration in 'WebKit::WebViewImpl' >> void WebViewImpl::showSafeBrowsingWarning(const SafeBrowsingWarning& >> warning, CompletionHandler<void(Variant<ContinueUnsafeLoad, URL>&&)>&& >> completionHandler) >> ^~~~~~~~~~~~~~~~~~~~~~~ >> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2801:22: >> error: instance method '-dismiss' not found (return type defaults to 'id') >> [-Werror,-Wobjc-method-access] >> [_shareSheet dismiss]; >> ^~~~~~~ >> ----------------- >> >> Filed a bug to track: https://bugs.webkit.org/show_bug.cgi?id=192479 >> <https://bugs.webkit.org/show_bug.cgi?id=192479> >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] <mailto:[email protected]> >> https://lists.webkit.org/mailman/listinfo/webkit-dev >
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
