Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles.
-Brent > On Jun 24, 2019, at 8:21 PM, Fujii Hironori <fujii.hiron...@gmail.com> wrote: > > Hi, > > I'm going to bump cmake_minimum_required version to 3.10 for > shining new features. > > Bug 199181 – [CMake] Bump cmake_minimum_required version to 3.10 > https://bugs.webkit.org/show_bug.cgi?id=199181 > <https://bugs.webkit.org/show_bug.cgi?id=199181> > GTK and WPE's EWS and BuildBot bots maintainers, could you please > update your CMake on your bots? > > If you are using CMake Visual Studio generator, you need CMake > 3.12 or newer to avoid an unnecessary recompilation issue. > > AppleWin port seems still using old Visual Studio 2017. If it > will switch to Visual Studio 2019 for better C++17 support, > Visual Studio 2019 needs CMake 3.14 or newer. > https://cmake.org/cmake/help/v3.14/release/3.14.html#generators > <https://cmake.org/cmake/help/v3.14/release/3.14.html#generators> > Happy WebKit 18th > <https://webkit.org/blog/6888/celebrating-15-years-of-webkit/>birthday > <https://donmelton.com/2017/06/25/sweet-sixteen-for-safari-and-webkit/>🎂 > > -- Fujii > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
