On Wed, May 23, 2012 at 9:41 AM, Mario Sanchez Prada <[email protected]> wrote: > - You're adding new API to WK1 -> you need to add Unit tests. > > - As I said before, I think adding the API for mime types > would be a good idea, now you're proposing this. This means > webkit_file_chooser_request_get_mime_types_filter at least. > > - Also, I'd add the rest of the API present in WK2. Namely: > webkit_file_chooser_request_get_mime_types > webkit_file_chooser_request_get_selected_files > > > About the last two items, see the second patch attached here, where I > already added the needed code (and roughly tested it manually), which > was a fairly immediate task. > > However, I'm afraid I can't now deal with the implementation of the unit > test, which will for sure take way more time, so if you could do that > yourself, I'll be happy to re-run the check-webkit-patch script again, > and also the prepareChangeLog one, once you're done with that, if that's > ok to you. > > Also, don't forget to file a new bug about this, so we can continue the > discussion and development there more easily.
Thanks so much for helping out here! I've filed https://bugs.webkit.org/show_bug.cgi?id=87283 with your work rolled into my initial backport. Adding the unit tests looks a bit tricky indeed. I'm also a bit overloaded right now but I'll do my best to find some time soon. Any help or advice here would be very welcome. Thanks, Daniel _______________________________________________ webkit-gtk mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-gtk
