On 21.09.2010 5:29, Chris Hatko wrote:
Hi I'm trying to put together a download manager under webkit cairo.I've implemented a download handler via "IWebDownloadDelegate". I register this download delegate by calling " setDownloadDelegate " in my webview. When I try to download a file I can see that "WebFrame::download(ResourceHandle* handle, const ResourceRequest& request, const ResourceRequest&, const ResourceResponse& response) " gets called and it seems to correctly find a pointer to my delegate. However none of my delegates functions are ever called and hence I can't download the file. Any ideas as to what i'm missing in this procedure?
I think it's because WebDownloadCurl is not implemented as of currenttrunk: http://trac.webkit.org/browser/trunk/WebKit/win/WebDownloadCurl.cpp#L63
Now I have this possibly incomplete patch (attached) to implement that. It works for me, but I never took the time get it reviewed/accepted, sorry.
One thing I was forced to do is adding reference counting to ResourceHandleClient in order to support wasCancelled() callback. This resulted in rather large amount of small changes to files where the client is used, so I never really liked this part of the patch.
Comments are welcome. :) -- AlexPS: the patch is not against current trunk, but r57813, so it might not apply cleanly. :-/ You were warned.
0019-Implemented-WebDownloadCurl-on-Win32.-Changed-Resour.patch.gz
Description: application/gzip
_______________________________________________ webkit-help mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-help
