Re: [webkit-help] Styling issue with -expected.png files during svn_create_patch and fails on build bots.[Win-7/Cygwin]

[Sravan]

Hi Julien,

Yes, you are right, as the script does'nt really handle such kind of
footer, it seems to be a bug.
As i have devoted too much time to it initially, i thought i will give a
break for it and come back, so that i might get some fresh ideas. Any how
its always in back of my mind, and i am thinking to fix the script and then
post relevant BUG. Also, if possible i am planning to try the same from
Linux machine too, just to make sure i am not stuck with windows specific
svn problems.

Thanks a lot for all the info provided. Will try Tools/Scripts/webkit-patch
too.
Please kindly let me know if u want me to include you in the CC list in
case i file a bug on this?

-Sravan

On Wed, Feb 29, 2012 at 11:36 AM, Julien Chaffraix <
julien.chaffr...@gmail.com> wrote:

> Hi Sravan,
>
> > Thanks for the response, but i have done that too. Infact i tried
> sneaking
> > in to scripts responsible for creating the patch and applying the patch,
> > following is my observation(which i have posted on
> > https://bugs.webkit.org/show_bug.cgi?id=78684)
> >
>
> [snipped the explanation]
>
> This sounds like a bug. I have seen some warnings using SVN when
> gardening several weeks ago so it may not be only you.I haven't filed
> a bug at the time and now I don't have the errors handy :(
>
> That said I don't know how svn-create-patch works these days so it's
> better to file a bug and get the relevant people to look into it.
>
> > I just want to know if my cygwin settings are wrong? or svn configuration
> > settings are wrong? or do i have to leave this and find an alternate
> method
> > to upload the patch?.
>
> If you have tried the previous link I send, I really don't enough svn
> / cygwin magic to help you.
>
> > Initially i thought its a svn diff related problem but since everybody is
> > uploading patches, i  am holding back on that assumption. i tried to
> look at
> > change logs for some references on patch, but i found that almost all of
> > them are using git diff, so it dint help me much.
> >
> > Can u please  suggest what is the alternative to upload the patch.
>
> Using "Tools/Scripts/webkit-patch upload" would like lead to the same
> error if it's lower level that our tools but it's worth a try.
>
> Another alternative is using git.
>
> If you are really hitting some bugs in our tool, just fixing them
> would be your best course of actions. Make sure you get someone who
> knows this to acknowledge the issue as I don't know what's going on.
>
> Thanks,
> Julien
> _______________________________________________
> webkit-help mailing list
> webkit-help@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-help
>

_______________________________________________
webkit-help mailing list
webkit-help@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-help