> > One thing that is still missing is an equivalent to QWebPage::view(). You > can get a QWidget from QWebPage, but you cannot get QGraphicsWidget from > QWebPage. Is this something you are planning to add in the near future? >
Yes, Yael, that is right. And I think that this is the only inconsistency with the patch. We could add an API for this later, or at least something private that can be exported and stay hidden. I still think that the best solution for supporting both use cases would be to have a common interface to QWidget and QGraphicsWidget specially designed for being a webview. Well, but this is something for the future... In Symbian, are you using custom QGraphicsWidgets as webviews or are you all using QGraphicsWebView? This would help answering some of Simon's questions: why do we need this? Where is QGraphicsWebView failing? Thanks for all comments! Jesus > > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *ext Jesus > Sanchez-Palencia > *Sent:* Thursday, April 29, 2010 9:03 AM > *To:* [email protected] > *Subject:* [webkit-qt] PageClient Refactor and a new setView() use case > > > > Hello there, QtWebKit hackers! > > > > I've been working on a PageClient refactor for QtWebKit. > > The main motivation for this came from the fact that nowadays our API > has QWebPage::setView(QWidget*) but has nothing to deal with > QGraphicsWidgets. > > People were starting to do QWebPage::setView(QGraphicsView*), but this was > leading us to bugs since the API is not ready to deal with the QGraphicsView > family. > > > > So, I've prepared 2 patches for this: > > > > - one refactor for the QWidget's PageClient ( > https://bugs.webkit.org/show_bug.cgi?id=37858), which is already landed; > > > > - and a more complex one for adding a QGraphicsWidget PageClient and a > QWebPage::setView(QGraphicsWidget*) ( > https://bugs.webkit.org/show_bug.cgi?id=37866). > > > > > > This last one, basically, moved code from QGraphicsWebViewPrivate > (including Tiling and AC specific stuff) to a "real" PageClient and removed > the inheritance from it (this private class _was_, in fact, the PageClient > of the QGraphicsWebView). > > > > I'd like some feedback from you in order to understand what do you think > about this patch and if you consider this new setView API a valid use case > or not. > > I'm aware that Plasma (from KDE) is using it and that it might be useful > for the QML folks. > > > > Also, should this go into QtWebKit 2.0 or should we just leave it for > QtWebKit 2.1? > > > > I already have the r+ for the patch, but we agreed to wait for this > discussion before deciding when to land it. > > > > > > Best regards, > > Jesus >
_______________________________________________ webkit-qt mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
