Hi all,

Thanks for Allan's and Coda's comments. I opened new bug 102057 for this issue. 
Attached is my patch for it. With my patch, I can successfully compile webkit23 
on Mac via command 'QTDIR=/usr/local/Trolltech/Qt-4.8.4 nohup 
Tools/Scripts/build-webkit --qt --no-video -spec macx-g++'. Could you please 
review my patch?

Thanks,
Bobber

-----Original Message-----
From: [email protected] 
[mailto:[email protected]] On Behalf Of Allan Sandfeld Jensen
Sent: Tuesday, November 13, 2012 2:09 AM
To: [email protected]
Subject: Re: [webkit-qt] Cannot build QtWebKit 2.3 with latest Qt 4.8.4 on Mac

On Monday 12 November 2012, Cheng, Bobber wrote:
> Hi all,
> 
> I downloaded QtWebKit 2.3 from gitorious:
> https://gitorious.org/+qtwebkit-developers/webkit/qtwebkit-23/ and 
> trie to compile it on Mac OSX with latest Qt 4.8.4 (build from latest git 
> code).
> Building failed and I found that there are many code that depend on Qt5.
> e.g. QWindow. Could anyone please kindly tell me if there are any 
> special setting to compile QtWebKit 2.3 on Mac?
> 
There are no special settings, unfortunately the branch is only tested 
regularly on Linux. So if you find specific problems and workarounds please 
open bugs for it or ask here. I can almost guarantee it is not going to work 
without a few build-system fixes on both Windows and Mac. The build system is 
the part where QtWebKit2.3 has diverged most from trunk (due to some otherwise 
really nice build system improvements in trunk that depend on Qt5 QMake).

Please note that QtWebKit 2.3 is not a part of any official Qt release and is 
not scheduled to be. It is a community Qt project to provide a more uptodate 
WebKit for Qt 4.x. Which means we also need your support to help develop and 
maintain it.

I will be happy to review any patches any one has that might help. You can also 
try skipping back half a month at a time and see if you can find the merge 
where Mac builds broke. QtWebKit2.3 was branched from trunk in early August, 
but has been following trunk since in twice weekly merges, with only the 
patches that would break it skipped or rewritten. 

Btw when opening bugs on QtWebKit2.3, you should make it block bug 88186 which 
tracks all QtWebKit2.3 issues.  Otherwise we are sure to miss it.

Best regards
`Allan
_______________________________________________
webkit-qt mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-qt

Attachment: patch_102057
Description: patch_102057

_______________________________________________
webkit-qt mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-qt

Reply via email to