On Thu, Feb 12, 2009 at 4:35 AM, Leslie P. Polzer <[email protected]> wrote:
> http://bitbucket.org/coffeemug/weblocks-slava/changeset/c0f63e7cd805/
> The browser-supplied name is not 8-bit safe due to a nasty bug in
> librfc2388.
Thanks, I fixed this except I used hunchentoot::octets-to-string
instead of sb-ext:octets-to-string for portability (I trust it to
import the symbol from proper places on different implementations).

> http://bitbucket.org/coffeemug/weblocks-slava/changeset/f9af7daa8e27/
> Why are integer and float parser in parsers/common.lisp and not in
> separate files?
I think the idea was that these are parsers for commonly used
"primitive" data types. So no real reason, other than lack of need to
split the file up.

> http://bitbucket.org/coffeemug/weblocks-slava/changeset/2a57103fa2e0/
> Why do you make it statically depend on html-template?
I'm not sure now why I added template-block widget to weblocks proper.
I actually don't like html-template library - the templating language
is too restrictive (why not just make it Lisp). I'll probably change
this, so I'd ignore this changeset too.

> http://bitbucket.org/coffeemug/weblocks-slava/changeset/434096153bf4/
> What's going on here? The commit message isn't really helpful, and the
> hunks are pretty large. The last hunk is definitely a candidate, but I'd be
> grateful if you could tell me a bit about the others.
I changed render-menu to support ordered and unordered lists (it only
rendered unordered lists before). The rationale is that I use
render-menu for wizards and guides that have a distinct order of
steps.

> http://bitbucket.org/coffeemug/weblocks-slava/changeset/93642076d03c/
> Hrm, not sure how that fix works/what cases it affects. Guess it's
> another one of those "oh no, we've been comparing pane-info, attributized,
> symbol, cased string all wrong" nav things...
Yep, it's one of those.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"weblocks" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/weblocks?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to