Vyacheslav Akhmechet <[email protected]> writes: > I needed the ability to index and lookup widgets by dom-id, so I added > it to my branch (weblocks-slava on bitbucket). I'll do the merge > eventually, but meanwhile I know some people were interested in this, > so I'm attaching a diff. > > Requires trivial-garbage for portable weak hashtables.
Interesting -- I have some questions: 1. You seem to introduce a dom-id concept which could be different from :name initarg -- are they different concepts? If so, what is the purpose of :name? 2. Do you need the lookups to be fast? If you don't, you could simply walk the tree to find your widgets, without maintaining a separate data structure in parallel. In fact I think I saw this functionality in a patch somewhere recently. 3. Could you please describe the use case for this? I'm curious, as I've never found one. 4. Did you consider the fact that your code will also find widgets which are not in the currently rendered document (DOM)? If flows replace some widgets, the hash table will not know about it. I don't know if this matters to you, but it probably should be part of the specification. --J. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
