Hey Guys,
First off sorry for not replying earlier but it is a hectic week okay
so here goes:
> Please try to put only things that belong together into your commits.
> 'hg record' is helpful for doing this.
>
> Likewise please provide specific commit messages that show what
> has changed in a synoptical way.
>
You are absolutely right, I should have taken the time to read a bit
more about mercurial before I started uploading.
> * please try to keep your lines (including docstrings) roughly to 80
> characters.
fair enough. Any other coding standards we are following?
> * define-client-backend: not sure if this should be a DEFVAR instead
> of a DEFPARAMETER...
Well I was thinking I wanted to overwrite the same symbol name so in
case we provide some symbol say jquery by default the user would be
able to change it by simply calling define-client-backend with symbol
jquery later on while if it was DEFVAR then he is stuck with the
default setup.
> * make-backend-dependency: I haven't checked more closely but
> it seems to contain a lot of code already found in make-local-
> dependency
> (or some other dep function). Is there a way to merge them?
I believe so, I started with a copy of make-local-dependency but had
changes specific to the ajax-backend but if memory serves I ended up
reverting to almost the same thing. I will check and merge if
possible.
> * build-client-backend: let's use NCONC here instead of APPEND.
> This dep stuff is in the performance-critical path.
Thanks for the tip did not know that nconc had a shorter execution
then APPEND. (by the way any suggestions how i can profile/debug
weblocks while i am running it a service ie with hunchentoot serving
the pages)
> * test HCR-10 (I think): prototype isn't quoted. This test
> will fail.
I believe you were looking at not the final commit since the final
commit I uploaded had passed all the tests.
> * 6ebd733f23b9: do we need the *.0.* files in the repository?
> (This is not a rhetorical question, I'm unsure myself)
No not at all. Did not even realize that I had uploaded those will be
more careful.
> * ibid.: alert("Oops. You do not have a backend defined")
> -- let's abstract that into a function called whenever
> there's no backend. We should also take into account
> partial implementations -- some backends might not
> have effects stuff for example.
Sure I will abstract that to one function. However there are no
effects that are in the core file that we have (I think) and all
should be implemented as I understood so correct me if I am wrong.
I will try to do the above list in the coming two days or early next
week (hectic weekend sorry).
Regards,
Mackram
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"weblocks" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/weblocks?hl=en
-~----------~----~----~----~------~----~------~--~---
