Eric S. Johansson writes:
> Justin Mason explained:
> > "Eric S. Johansson" writes:
> >>>The fileparse() error looks very wierd.  What should be happening is that
> >>>the "wmkf" parameter to the CGI has not been given, so it'll ask you
> >>>to choose a webmake .wmk file to start with.

OK -- looks like a bug :(

Something must have changed in the dependency modules there -- my guess is
File::Basename::dirname no longer accepts undef as an argument, and now dies in
that case.   The host I'm running webmake.cgi on, is still on perl 5.6, so
this hasn't shown up there yet.

this patch fixes it, and is now in CVS:

diff -u -3 -p -r1.26 CGIBase.pm
--- lib/HTML/WebMake/CGI/CGIBase.pm     8 Apr 2003 01:25:18 -0000       1.26
+++ lib/HTML/WebMake/CGI/CGIBase.pm     28 Aug 2003 23:11:35 -0000
@@ -284,9 +284,11 @@ sub run {
   # this may be overridden in Site.pm, the module for editing .wmk files
 
   # check to see if CVS is available in this subdir
-  my $base = File::Basename::dirname ($self->{wmkfile});
-  if (-d $self->{file_base}."/".$base."/CVS") {
-    $self->{cvs_supported} = 1;
+  if ($self->{wmkfile}) {
+    my $base = File::Basename::dirname ($self->{wmkfile});
+    if (-d $self->{file_base}."/".$base."/CVS") {
+      $self->{cvs_supported} = 1;
+    }
   }
 
   $self->{cvsadd} = &mksafepathlist($q->param('cvsadd'));
_______________________________________________
Webmake-talk mailing list
[EMAIL PROTECTED]
http://webmake.taint.org/mailman/listinfo/webmake-talk

Reply via email to