Hi All -
Many thanks to everyone for their help with my recent deadlock issue.
I think we may well have nailed it as we've managed 18 hours now
without a blip. Particular thanks goes to the authors of the
ScreamingEditingContext whose logging has been our saviour.
We do however have one issue that continues to scream:
!!! editing context being disposed with 1 locks. !!! Most recently
locked by: java.lang.Throwable at
com.clicktravel.plumbing.system.ScreamingEditingContext._trace
(ScreamingEditingContext.java:52) at
com.clicktravel.plumbing.system.ScreamingEditingContext.lock
(ScreamingEditingContext.java:113) at
com.webobjects.appserver.WOSession._awakeInContext(WOSession.java:
717) at com.webobjects.appserver.WOApplication.restoreSessionWithID
(WOApplication.java:1550) at
er.extensions.ERXApplication.restoreSessionWithID(ERXApplication.java:
1432) at com.webobjects.appserver.WOAction.existingSession
(WOAction.java:164) at
com.clicktravel.plumbing.components.CTDirectAction.performActionNamed
(CTDirectAction.java:133) at
com.webobjects.appserver._private.WOActionRequestHandler._handleRequest(
WOActionRequestHandler.java:240) at
com.webobjects.appserver._private.WOActionRequestHandler.handleRequest
(WOActionRequestHandler.java:145) at
er.extensions.ERXDirectActionRequestHandler.handleRequest
(ERXDirectActionRequestHandler.java:82) at
com.webobjects.appserver.WOApplication.dispatchRequest
(WOApplication.java:1306) at
er.extensions.ERXApplication.dispatchRequest(ERXApplication.java:
1161) at com.webobjects.appserver._private.WOWorkerThread.runOnce
(WOWorkerThread.java:173) at
com.webobjects.appserver._private.WOWorkerThread.run
(WOWorkerThread.java:254) at java.lang.Thread.run(Thread.java:613)
I know exactly where this is coming from: session().terminate() when
a user logs out. The question is should we be worried about it ? The
source of the ScreamingEditingContext suggests binning an EC with a
lock on it is bad practice, so I guess we should tidy it up but i'm a
bit concerned about the inner-workings of WO and whether overriding
terminate() is a good thing. This fixes the problem:
public void terminate() {
this.defaultEditingContext().unlock(); // Not sure why WO doesn't do
this itself ?
super.terminate();
}
Can anyone see a problem with that ?
Thanks, Simon
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list ([email protected])
Help/Unsubscribe/Update your Subscription:
http://lists.apple.com/mailman/options/webobjects-dev/archive%40mail-archive.com
This email sent to [EMAIL PROTECTED]
