Thank you Johann, that should get me going. The MANIFEST in the jar files says that they were built with java 1.7.0_79. I am going to try to find out if they are compatible with java 5, but based on the manifest it would be safer to keep this only in master as it may require > java 5.
Thanks > On Nov 30, 2015, at 4:30 PM, Johann Werner <j...@oyosys.de> wrote: > > Hi Ricardo, > > you should create a branch off from the official master branch and make your > changes on that one. How to do that depends on the way you interact with git > (e.g. git command line, Tower, SourceTree, …). > > Then you can create your pull request against the master branch. If the > flying saucer jars are compatible with Java 5 it will be possible to cherry > pick your changes into wonder_6 afterwards otherwise it will be Wonder 7 > only. Do not use the wonder_7 branch as it points to an old state of master. > I think that branch should go away soon to not confuse users. Master is the > current Wonder 7. > > For more info you can check the corresponding wiki page: > https://github.com/wocommunity/wonder/wiki/Creating-and-submitting-an-acceptable-patch > > jw > > >> Am 30.11.2015 um 19:40 schrieb Ricardo Parada <rpar...@mac.com>: >> >> Hi all, >> >> I was trying to create a pull request to remove core-rederer-20101006.jar >> from ERPDFGeneration and add flying-saucer-core-9.0.8.jar and >> flying-saucer-pdf-9.0.8.jar. >> >> However the fork I have of wonder on my github account is really old and I’m >> confused how to go about doing this. I’m not even sure what branch to put >> it on. My fork of wonder only has master, integration, and >> Wonder_5_0_0_Legacy. I was expecting to see master, wonder_5, wonder_6 and >> wonder_7. >> >> Is there any documentation on how to go about submitting a pull request for >> wonder? >> >> Thanks >> Ricardo >> >> >> >>> On Nov 18, 2015, at 4:28 PM, Ricardo Parada <rpar...@mac.com> wrote: >>> >>> Thank you Timo and Samuel for your responses. >>> >>> The easiest for me was to just update the flying saucer library to 9.0.8 as >>> Timo suggested. I can now use the .pdf logo with vector graphics. The logo >>> now looks beautiful on the Retina display. >>> >>> >>> >>> On Nov 17, 2015, at 3:33 PM, Timo Hoepfner <th-...@onlinehome.de> wrote: >>> >>>> Hi Ricardo, >>>> >>>> not at my work machine currently, but I came across a similar problem >>>> recently. In my case I tried to use a PDF as background image and got the >>>> same error. Updating flying saucer to a more recent version solved the >>>> issue for me. The jars I’m currently using are >>>> flying-saucer-core-9.0.8.jar and flying-saucer-pdf-9.0.8.jar. I think they >>>> replace the core-renderer-20101006.jar in ERPDFGeneration. The commit >>>> you’re after is probably this one: >>>> >>>> https://github.com/flyingsaucerproject/flyingsaucer/commit/26bf700857252ac04ecadd98dc0f8a2209e3c7f8 >>>> >>>> HTH, >>>> >>>> Timo >>>> >>>> >>>>> Am 17.11.2015 um 18:01 schrieb Ricardo Parada <rpar...@mac.com>: >>>>> >>>>> Hi all, >>>>> >>>>> We use ERPDFWrapper to generate PDF from a WOComponent. It comes out >>>>> beautiful. >>>>> >>>>> One of our components includes a logo using the <img> html tag and the >>>>> logo is usually a .gif or .jpg. However, I would like to use vector >>>>> graphics. We took a .eps file and converted it to .pdf in Photoshop. >>>>> The resulting image scales beautifully to any size. When I try to use >>>>> the .pdf I get java.lang.ClassCastException: >>>>> org.xhtmlrenderer.pdf.PDFAsImage cannot be cast to >>>>> org.xhtmlrenderer.pdf.ITextFSImage. >>>>> >>>>> Has anybody been able to use vector graphics in ERPDFWrapper? >>>>> >>>>> Thanks >>>>> >>>>> The stack trace is below: >>>>> >>>>> java.lang.ClassCastException: org.xhtmlrenderer.pdf.PDFAsImage cannot be >>>>> cast to org.xhtmlrenderer.pdf.ITextFSImage >>>>> at >>>>> org.xhtmlrenderer.pdf.ITextUserAgent.getImageResource(ITextUserAgent.java:97) >>>>> at >>>>> org.xhtmlrenderer.pdf.ITextReplacedElementFactory.createReplacedElement(ITextReplacedElementFactory.java:57) >>>>> at >>>>> er.pdf.builder.ERPDFReplacedElementFactory.createReplacedElement(ERPDFReplacedElementFactory.java:50) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.calcMinMaxWidth(BlockBox.java:1439) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.calcMinMaxWidthInlineChildren(BlockBox.java:1584) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.calcMinMaxWidth(BlockBox.java:1481) >>>>> at >>>>> org.xhtmlrenderer.newtable.TableBox$AutoTableLayout.recalcColumn(TableBox.java:1240) >>>>> at >>>>> org.xhtmlrenderer.newtable.TableBox$AutoTableLayout.fullRecalc(TableBox.java:1214) >>>>> at >>>>> org.xhtmlrenderer.newtable.TableBox$AutoTableLayout.calcMinMaxWidth(TableBox.java:1509) >>>>> at >>>>> org.xhtmlrenderer.newtable.TableBox.calcMinMaxWidth(TableBox.java:158) >>>>> at >>>>> org.xhtmlrenderer.newtable.TableBox.layout(TableBox.java:221) >>>>> at >>>>> org.xhtmlrenderer.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321) >>>>> at >>>>> org.xhtmlrenderer.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299) >>>>> at >>>>> org.xhtmlrenderer.layout.BlockBoxing.layoutContent(BlockBoxing.java:90) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.layoutChildren(BlockBox.java:926) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.layout(BlockBox.java:806) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.layout(BlockBox.java:735) >>>>> at >>>>> org.xhtmlrenderer.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321) >>>>> at >>>>> org.xhtmlrenderer.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299) >>>>> at >>>>> org.xhtmlrenderer.layout.BlockBoxing.layoutContent(BlockBoxing.java:90) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.layoutChildren(BlockBox.java:926) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.layout(BlockBox.java:806) >>>>> at >>>>> org.xhtmlrenderer.render.BlockBox.layout(BlockBox.java:735) >>>>> at >>>>> org.xhtmlrenderer.pdf.ITextRenderer.layout(ITextRenderer.java:216) >>>>> at >>>>> er.pdf.builder.FlyingSaucerImpl.setSource(FlyingSaucerImpl.java:99) >>>>> at er.pdf.ERPDFUtilities.htmlAsPdf(ERPDFUtilities.java:123) >>>>> at er.pdf.ERPDFWrapper.responseAsPdf(ERPDFWrapper.java:75) >>>>> at >>>>> er.pdf.ERPDFWrapper.appendToResponse(ERPDFWrapper.java:60) >>>>> at >>>>> com.webobjects.appserver.WOComponent.appendToResponse(WOComponent.java:1122) >>>>> at >>>>> er.extensions.components.ERXComponent.appendToResponse(ERXComponent.java:117) >>>>> at >>>>> er.extensions.components.ERXNonSynchronizingComponent.appendToResponse(ERXNonSynchronizingComponent.java:73) >>>>> at >>>>> com.mpv.webcomponents.MPVWOComponent.appendToResponse(MPVWOComponent.java:67) >>>>> at >>>>> com.webobjects.appserver.WOSession.appendToResponse(WOSession.java:1385) >>>>> at >>>>> er.extensions.appserver.ERXSession.appendToResponse(ERXSession.java:552) >>>>> ... >>>>> >>>>> _______________________________________________ >>>>> Do not post admin requests to the list. They will be ignored. >>>>> Webobjects-dev mailing list (Webobjects-dev@lists.apple.com) >>>>> Help/Unsubscribe/Update your Subscription: >>>>> https://lists.apple.com/mailman/options/webobjects-dev/th-dev%40onlinehome.de >>>>> >>>>> This email sent to th-...@onlinehome.de >>>> >>> _______________________________________________ >>> Do not post admin requests to the list. They will be ignored. >>> Webobjects-dev mailing list (Webobjects-dev@lists.apple.com) >>> Help/Unsubscribe/Update your Subscription: >>> https://lists.apple.com/mailman/options/webobjects-dev/rparada%40mac.com >>> >>> This email sent to rpar...@mac.com >> > _______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (Webobjects-dev@lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/archive%40mail-archive.com This email sent to arch...@mail-archive.com
