Sriram Natarajan wrote:
>
> Jyri / Team
> Please find the updated version here which incorporates review comments
> -
> http://wikis.sun.com/download/attachments/10390064/php-5211-arc-draft-v1.txt
> 2.8 Packaging and Delivery
...
> We propose to drop bundling 'dtrace.so' within SUNWphp52u
> package. This extension has been rolled into PHP engine itself.
> So, there should be no loss of functionality or change in behavior
> with this change.
Before going for ARC review you need to be sure of whether there will
be any loss of functionality or change in behavior. If this is still
in doubt, hold off on the case until answer is known.
> 3.3.1 PHP Packages
>
> NAME STABILITY NOTES
>
> SUNWphp52u-apc Volatile Volatile because 3rd
> party extensions can change any time.
That's ambiguous. What kind of changes will lead to the package
name SUNWphp52u-apc (and others listed below) to suddenly change with
no warning? I can think of
- We suddenly stop shipping APC for PHP 5.2.*
- We suddenly embed APC back in the core PHP 5.2.* package and drop the
individual package (although this doesn't force the SUNWphp52u-apc package
to disappear, it could remain as a dummy package, which I believe is how
IPS handles such refactorings anyway).
Is this expected to happen in PHP 5.2.* lifetime?
(For package names, specifically, this is somewhat academic because IPS
is renaming packages outside the context of ARC anyway. However it is
still good engineering practice to consider carefully what are the
interfaces, their stabilities and most importantly, why.)
> /etc/php/5.2/conf.d/ncurses.ini Volatile Volatile
> because 3rd party extensions can change any time.
Again this is ambiguous and comes across as handwaving. ARC doesn't
like handwavy answers ;-) Explain what and why and how you will document
it so customers can deal with the pain?
Is it the syntax of the *.ini files that you expect will change at any
time without notice in future PHP 5.2.* bugfixes? Or the location of
the file? Both?
Also: are these *.ini files preserved during upgrade ('renamenew')?
If yes, what happens to a customer's PHP 5.2 installation when the
file syntax suddenly changes and the PHP 5.2 binary gets updated
during upgrade but their old ncurses.ini file stays behind because
they hand-edited it? PHP just crashes on startup? Or refuses to
start? Or starts but automatically disables the offending extension?
Or, something else?
--
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
