Update WebRev with your suggestions addressed.
http://cr.opensolaris.org/~tekgrrl/gems131-CR6764580-2/
Thanks
Amanda
Prashant Srinivasan wrote:
> Amanda waite wrote:
>
>> Chris Zhu wrote:
>>
>>
>>> Hi Amanda,
>>>
>>> I just found there's another repository location for rubygem in
>>> /usr/ruby/1.8/lib/ruby/gems/1.8/, although gems will be installed in
>>> /var/ruby/1.8/gem_home, as we it as the GEM_HOME. And we can find
>>> /usr/ruby/1.8/lib/ruby/gems/1.8 is still listed in the GEM PATH when
>>> we run "gem environment"
>>>
>>>
>> Yes, I know. This allows us as the vendor to install Gems to
>> /usr/ruby/1.8/lib/ruby/gems/1.8/ and users to install them to
>> /var/ruby/1.8/gem_home. This means that user supplied Gems don't
>> overwrite vendor supplied gems. This is all part of the plan
>>
>>
>>
>>> My advice is to set /var/ruby/1.8/gem_home to
>>> rubygems-1.3.1/lib/rubygems/defaults.rb, and there's no needs to add
>>> GEM_HOME to rbconfig.rb in install-sfw again.
>>>
>>>
>> I'd prefer it if we keep all the 'defaults' changes to one file, i.e.:
>> rbconfig.rb. There were changes made to other files in the original
>> integration and these were hard to find.
>>
>
> I agree that we should use rbconfig.rb for these changes - apart from
> cleanliness, a practical problem with defaults.rb is that if someone
> decides to upgrade outside of IPS, our modifications will be lost. We
> don't recommend that people upgrade outside of IPS, but if they want to
> do that, lets try not to be unfriendly.
>
> Can we please remove the patch to defaults.rb as a part of the rubygems
> integration, since this integration adds the rbconfig.rb entry to
> replace the defaults.rb patch?
>
> thanks
> -ps
>
>
>
>
>> Your change also doesn't set
>> the 'EXECUTABLE DIRECTORY' to ${GEM_HOME/bin} which is what it should
>> be, user installed gems cannot install binaries into /usr.
>>
>>
>>
>>> See the workspace in
>>> /net/dn18.sfbay.sun.com/export/workspace/chriszhu/ruby187/WS/usr/src/cmd/ruby18/patches/gem_defaults.patch
>>> BTW, what's the function of rubygems_setup.patch
>>>
>>>
>> It modifies the shebang line generated for the 'gem' program. Without
>> this it would be ${ROOT}/usr/ruby/1.8/bin/ruby. Look at the shebang on
>> ${ROOT}/usr/ruby/1.8/bin/gem on your workspace.
>>
>> Amanda
>>
>>
>>
>
> _______________________________________________
>
>
> webstack-discuss mailing list
> webstack-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
>
