Seema Alevoor wrote:
> Hi,
>
> Please review the webrev for CR 6782657 at 
> http://cr.opensolaris.org/~seema/6782657/

+1 for this change

To consider in the future:
* This patch obviously doesn't help/hurt the worker build, but over the 
long haul it may be less confusing to keep the set of patches the same 
for all Apache builds (32 vs 64, prefork vs worker) except when 
absolutely necessary.
* We'll be re-syncing our Apache delivery with Apache every six months 
or so, but we can still have a handful of patches for fixes we want to 
deliver sooner (such as this one, not yet in an Apache release).  It 
would be nice to have something installed with the server which shows 
what has been fixed beyond the included Apache release.  A solution I've 
seen elsewhere is to install the CHANGES file from the included Apache 
release, with CHANGES entries for the applied patches at the top, above 
the "Changes with Apache 2.2.11" line.

BTW, I didn't see --enable-exception-hook in the configure options, but 
I thought I saw it in another webrev.  Perhaps I/we neglected to signal 
our review of it it?

Thanks!


Reply via email to