Seema Alevoor wrote:
> Please review the webrev at http://cr.opensolaris.org/~seema/6782613/
>
> Main changes:
> * --cflags includes CFLAGS and EXTRA_CFLAGS
> * --link-ld and --link-libtool options includes --ldflags option value.
>
These all sound like APR fixes, and not issues with our integration. Is
that right? What was broken? I just see the -m32/-m64 issue in the CR.
I understand that --cflags without the user-specified CFLAGS broke with
64-bit builds, and I've posted to dev at apr asking about the history (it
is a hindrance people have put up with for too long).
Why should --link-ld and --link-libtool include the --ldflags value too?
Why is the following change needed? (add -L$libdir if apr-1-config
hasn't been installed to its usual place)
++ if test -n "$install_root"; then
++ flags="$flags -L$libdir -l${APR_LIBNAME}"
++ else
++ flags="$flags -L$libdir -R$libdir -l${APR_LIBNAME}"
++ fi
Thanks!
