> -----Original Message-----
> From: sfwnv-discuss-bounces at opensolaris.org
> [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of
> Stefan Teleman
> Sent: 30 June 2008 14:42
> To: webstack-discuss at opensolaris.org; sfwnv-discuss at opensolaris.org
> Cc: Victor Kirkebo
> Subject: Re: [sfwnv-discuss] Request to review fix for CR
> 6717705 (memcached)
>
>
>
> Victor Kirkebo wrote:
> > Please find the webrev at
> > http://cr.opensolaris.org/~vk136562/memcached-1.2.5-CR6717705/
>
> Two questions:
>
> 1. Have you determined that -xO5 generates the best
> performing code on both SPARC and Intel. The fact that -xO5
> is the highest optimization level doesn't always mean it
> generates the fastest, best performing code. Aggressive
> inlining can sometimes lead to cache thrashing, which ends up
> having the exact opposite effect from the one intended.
>
> 2. ./configure --prefix=/usr
>
> Wouldn't it be better to say:
>
> PREFIX=/usr
>
> ./configure --prefix=$(PREFIX) \
Probably now it should really use the '--prefix=..' predefined in
Makefile.master now, eg ..
CONFIGURE_OPTIONS += --enable-threads
CONFIGURE_OPTIONS += --enable-dtrace
CONFIGURE_OPTIONS += --with-libevent=${ROOT}/usr)
CONFIGURE_OPTIONS += --localstatedir=/var
.....
./configure $(CONFIGURE_OPTIONS)
or something like that.
Paul
> [ ... ]
> --localstatedir=/var \
> [ ... ]
>
> By default, ./configure sets ${localstatedir} to
> ${prefix}/var. This will translate to /usr/var. If memcached
> needs to create temporary files in ${localstatedir}/tmp, it
> won't work (/usr/var/tmp can't exist in Solaris).
>
> What ./configure really means by ${localstatedir} is /var
> (and use /var/tmp for temporary, run-time files). My
> suggestion would be to change the call to ./configure and
> explicitly indicate the location of ${localstatedir} as /var.
>
> --Stefan
>
> ---
> Stefan Teleman
> Sun Microsystems, Inc.
> Stefan.Teleman at Sun.COM
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
