HI
- You might want to take a look at the indentation within
lighthttpd/Makefile.sfw
- Why not simply do it as gtar xf and avoid manually changing the
permission later
+ $(GTAR) xpf - --no-same-owner
+ touch $(LIGHTTPD)/configure
+ find $(LIGHTTPD) -type d -exec /usr/bin/chmod 755 "{}" \;
+ find $(LIGHTTPD) -type f -exec /usr/bin/chmod ugo+r "{}" \;
- Instead of using hard coded PHP path , you might want to use it in a
dynamic way. This is because PHP 5.2.6 integration is coming pretty soon
and is going to have a different file layout.
- With MySQL, you will now start the server as svcadm enable
mysql:version_50. Looks like, Apache and Lighttpd is going to start
their servers like svcadm enable http:apache22 and http:lighthttpd14.
Should we not all do this in a consistent way ? I guess, this is a
separate discussion.
- within the man page, there is a reference to memcached. Probably a
miss in cut and paste .
- While installing man pages, should we not use the convention of
_install M ?
- If the binaries and libraries are installed using _install , then we
can be sure that the symbols get stripped out. I see some components
doing this and some not. I am not sure, what is the convention within SFW ?
Hope this helps
Sriram
Amanda Waite wrote:
> Hi there,
>
> Before we do the putback on Lighttpd we'd like to get a few more
> eyeballs to go over the code and give us a thorough review. Not a great
> deal has changed since the last code review, but we have removed the
> horrible LD_LIBRARY_PATH statement from Makefile.sfw and no longer ask
> the configure script to use mysql_config.
>
> The code review is at http://cr.opensolaris.org/~tekgrrl/lighttpd-putback/
>
> We would really appreciate your feedback.
>
> Thanks
>
> Amanda - ISV-Engineering
> _______________________________________________
>
>
> webstack-discuss mailing list
> webstack-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
>
