Just looked at the webrev again -- looks good to me. Things to remember for the RTI:
1. When you file the RTI, please remember to attach all the diffs/patches to the Integration CR, as attachments (you can generate the diffs with 'wx pdiffs'). 2. Have a pointer to a brand new webrev, world-readable. 3. Have a putback -n output with no errors. :-) --Stefan ----- Victor Kirkebo wrote: > Stefan Teleman wrote: > >> usr/src/pkgdefs/SUNWmemcached/prototype_com: >> >> 51 f none usr/lib/libmemcache.a 0444 root bin >> >> There is no need to deliver the archive (*.a) library, since >> the the package delivers the shared library. >> > OK, I removed this file. > >> usr/src/Targetdirs: >> >> The HTML documentation for memcached should go in >> /usr/share/doc/memcached/html. Therefore you need a >> >> + /usr/share/doc/memcached \ >> + /usr/share/doc/memcached/html \ >> >> entry in Targetdirs. > > Done > >> >> usr/src/lib/memcached/install-sfw: >> >> HTML documentation installs in >> >> /usr/share/doc/<component>/html/*.html > > Done > >> >> usr/src/pkgdefs/Makefile: >> >> shouldn't the toplevel usr/src/pkgdefs Makefile include an entry for >> SUNWmemcached ? >> >> (otherwise SUNWmemcached* will not be packaged). > > Done (thanks Stefan) > >> >> --Stefan >> >> ------ >> >> Victor Kirkebo wrote: >> >>> Hi, >>> >>> Kindly find the webrev for memcached integration at : >>> >>> http://cr.opensolaris.org/~vk136562/memcached/ >>> >>> Code reviews are solicited from this team and review/feedback is >>> requested by 11/20. >>> >>> Regards, >>> Victor >> >> >> > -- Stefan Teleman Sun Microsystems, Inc. Stefan.Teleman at Sun.COM
