Luojia Chen wrote: > > Hi, > > I just post the webrev for 6638783 at: > http://cr.opensolaris.org/~luojiac/bugfix/ > > Can you please review this?
> Prepared by: Super-User (root) on Mon Dec 17 17:10:30 PST 2007 Looks like you're running as root for your development work. Not good practice! The code changes look ok. Some details to fix: Run "wx ea" and change the NO_COMMENT strings to the revision change comment, which in this case is: "6638783 following manpage instructions results in mysql user with inappropriate $HOME" (but without the quotes) After that run "wx redelget". This will modify the checkin comments for all files to the sfw practice of nothing but "bugid bugdescription". Then re-run "wx webrev" and update the URL above with the regenerated webrev output. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
