sunanda menon wrote: > Hi, > > We have replaced the mysql-5.1.37 tarball with that of patching the > mysql-5.1.37.tar.gz source from the download site. > Please review the changes made at > http://cr.opensolaris.org/~sunandam/6857014/ and let me know your > comments. > > Thanks Sunanda > >
Is there a separate CR covering the cflags change from -x04 to -x02? That should be called out in the webrev. -CXXCOMMONFLAGS= -DDBUG_OFF -DBIG_TABLES -DHAVE_RWLOCK_T -KPIC -DPIC -xO4 \ +CXXCOMMONFLAGS= -DDBUG_OFF -DBIG_TABLES -DHAVE_RWLOCK_T -KPIC -DPIC -xO2 \ -xprefetch=auto -xprefetch_level=3 -mt -fns=no -fsimple=1 -xbuiltin=%all \ -xlibmil -xlibmopt -norunpath @@ -56,7 +56,7 @@ CXX32FLAGS= $(CXXCOMMONFLAGS) # C common compiler flags -COMMONCFLAGS= -xO4 -xstrconst -xprefetch=auto -xprefetch_level=3 -mt\ +COMMONCFLAGS= -xO2 -xstrconst -xprefetch=auto -xprefetch_level=3 -mt\ That's the only thing I'm concerned about, but I guess finding/fixing that issue can be prioritized/resourced independently from getting the current failures resolved. +1 from me if the issue of -x02 can be clarified: * note the related CR with the webrev ** should be clear that lowering the optimization for the entire package is a work-around ** a CR should be kept open to investigate/resolve the underlying problem in some manner other than lowering the optimization for the entire package
