Thanks, Basant. I have removed that unused variable and updated the webrev. I will go ahead and file the WebRTI assuming no one has any further objections..
- Sriram Basant Kukreja wrote: > Patch looks ok to me but I found a minor issue in php_dtrace.patch. > dtrace_error_buffer seems to be a unused variable in php-5.2.11/Zend/zend.c > char dtrace_error_buffer[1024]; > > Regards, > Basant. > > > On Fri, Dec 18, 2009 at 01:28:19AM -0800, Sriram Natarajan wrote: > >> Hi >> I would like to commit the following bugs for build 131. Can you kindly >> look into the below webrev and provide your feedback. >> a) PHP to include 5.2.12 (6910254) >> b) Update DTrace probes to track object create / destroy functionality >> (6911767) >> >> WebRev: http://cr.opensolaris.org/~sn123202/php-b131.1/webrev/ >> >> Note: Build passes through successfully and no new regression is observed. >> _______________________________________________ >> >> >> webstack-discuss mailing list >> webstack-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >>
