Thanks for the review, Jeff. On 01/05/10 20:22, Jeff Trawick wrote: > Seema Alevoor wrote: >> Please review. >> >> Seema Alevoor wrote: >>> Hi, >>> >>> Please review the below webrevs. >>> >>> http://cr.opensolaris.org/~seema/6847117/ --> Integrate xerces c >>> libraries into SFW > a couple of nitpicks: > > xercesc-2.7/Patches/MsgCatalogLoader.cpp.patch.patch > > A more proper fix is to change the original code to > > if ( ((fCatalogHandle=catopen(catuser, 0)) == (nl_catd)-1) && > ((fCatalogHandle=catopen(catdefault, 0)) == (nl_catd)-1) ) > > > (aside from the more compact code, the error return value documented in > Solaris and OpenGroup docs is "(nl_catd) -1") > > xercesc-2.7/Patches/SolarisPlatformUtils.cpp.patch.patch > > IMO it is cleaner to zap the #include instead of comment it out > I have updated the webrev with the above changes.
Best Regards, Seema.
