Hi,
On Wed, 2010-01-06 at 14:26 -0800, Sriram Natarajan wrote:
> Hi
> ARC - 2009/667 is now approved. Hence, I would like to now request for
> code review to add support for Sun Web Server 7 within PHP. To enable
> this support, I had to compile PHP as NSAPI plugin and deliver all the
> PHP extensions (in multi-threaded mode). Your feedback on this is much
> appreciated. I hope to integrate this within build 132.
>
> http://cr.opensolaris.org/~sn123202/php-b132.1/webrev/
When having both PHP versions (zend thread-safe and not thread safe)
shouldn't there be both headers? - If I read this correctly users will
only get headers from the non-zts build so they can't build custom zts
modules.
At least(*) include/php/main/php_config.h will be different as it is
created while compiling (to be precise: running configure) PHP and hold
the preprocessor define whether ZTS is enabled or not.
Possibly having both headers around might be avoided by providing a
version of usr/php/5.2/bin/php-config which makes sure that either one
or the other php_config.h is included by these modules. Maybe it is even
enough to add -DZTS=1 -DPTHREADS=1 to the CFLAGS in ZTS mode.
(*) Other header files created include
/usr/php/5.2/include/php/main/build-defs.h
/usr/php/5.2/include/php/ext/sqlite/libsqlite/src/config.h
/usr/php/5.2/include/php/ext/sqlite/libsqlite/src/sqlite.h
/usr/php/5.2/include/php/ext/sqlite/iconv/*.h
/usr/php/5.2/include/php/ext/mysqlnd/php_mysqlnd_config.h
/usr/php/5.2/include/php/ext/date/lib/timelib_config.h
But as far as I can see their contents shouldn't depend on ZTS.
johannes
