At 01:22 PM 12/7/01 -0800, Chuck Esterbrook wrote: >On Thursday 06 December 2001 03:49 pm, Geoffrey Talvola wrote: > > At 06:43 PM 12/6/01 -0500, Geoffrey Talvola wrote: > > >At 12:32 PM 12/6/01 -0800, Tavis Rudd wrote: > > >>Why are method names different between ServletFactory and > > >>PythonServletFactory? > > >> > > >>ServletFactory.createServletForTransaction(...) > > >>PythonServletFactory.servletForTransaction(...) > > > > > >I think createServletForTransaction is actually dead code. I can't > > > find any place that actually calls it. If I'm right, we should > > > remove it from ServletFactory. > > > > Yup, I confirmed that it's dead code. I've removed the method in > > CVS. > > > > servletForTransaction() is of course still present in both > > ServletFactory and PythonServletFactory. > >Wait a minute. If servletForTransaction() is really being used, then >shouldn't we have renamed the "subclass responsibility method" >createServletForTransaction() instead of axing it? > >ServletFactory is the abstract superclass of all servlet factories and >should therefore define the base interface that is expected. Both for >documentation purposes and for giving more useful error messages than >"unknown attribute" when there are problems.
Oops. I should have renamed createServletForTransaction to servletForTransaction in ServletFactory instead of deleting it. I mistakenly thought there was already a servletForTransaction in ServletFactory but now that I've double-checked, there isn't. Someone must have partially renamed this method from createServletForTransaction to servletForTransaction in the past, but neglected to rename it in the base class. I'll fix it. Sorry about that. -- - Geoff Talvola [EMAIL PROTECTED] _______________________________________________ Webware-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/webware-devel
