StreamReader actually contains an implementation of the PSPReader class, and appears to be a successor to PSPReader.
For consistency should we just replace PSPReader with StreamReader (along with the corresponding change to PSPCompiler which currently imports PSPReader from StreamReader.
The last substantive change to PSPReader was done by Jay.
:revision 1.6
:date: 2000/06/02 23:19:09; author: jslove; state: Exp; lines: +15 -6
:Sync with local copy. Most likely won't use this anymore.
And the last change to PSPCompiler where it is used is:
:revision 1.2
:date: 2000/06/02 23:15:23; author: jslove; state: Exp; lines: +2 -2
:Using StreamReader instead of PSPReader.
Jay,
are you around, and care to comment?
- Stuart -
Geoffrey Talvola wrote:
Deleting the PSPReader.py file causes a traceback on starting the AppServer:Traceback (most recent call last): File ".\WebKit\AppServer.py", line 211, in loadPlugIn willNotLoadReason = plugIn.load() File ".\WebKit\PlugIn.py", line 60, in load self._module = __import__(self._name, globals(), [], []) File "PSP\__init__.py", line 5, in ? from PSPServletFactory import PSPServletFactory File "PSP\PSPServletFactory.py", line 31, in ? from PSP import Context, PSPCompiler File "PSP\PSPCompiler.py", line 29, in ? from ServletWriter import ServletWriter File "PSP\ServletWriter.py", line 30, in ? from PSPReader import * ImportError: No module named PSPReader So unless you feel like spending more time on this, I'd leave it alone for this release. If you do want to clean this up, then let's get rid of the "from PSPReader import *". Importing * is almost always a bad idea, and this shows why -- you can't easily tell what ServletWriter is using from PSPReader, if anything. - Geoff-----Original Message----- From: Stuart Donaldson [mailto:[EMAIL PROTECTED]] Sent: Friday, January 17, 2003 12:10 PM To: Webware devel Subject: [Webware-devel] PSPReader obsolete? Can we get rid of PSPReader? It appears to be obsolete. In its place, StreamReader.PSPReader is used. -Stuart-
