On Mon, 2003-07-28 at 22:17, Chuck Esterbrook wrote: > On Mon, 28 Jul 2003 15:34:04 -0400, Geoffrey Talvola wrote: > >> If caching wasn't done in the factory, I think it should be. I > >> think that just means we have to have a method to return the > >> servlet to the factory, and then the factory can keep a pool of > >> servlets. > >> > > I agree -- the caching belongs in the factory, not in Application. > > I believe I originally put it in the Application so that each servlet > factory would not have to reinvent caching. > > For example, I often add a servlet factory for HTML fragment files > (.htmlf). Do I now I have to reimplement/copy the code for caching of > servlets in this factory? Or can I inherit it from some MixIn util > class? > > I didn't make the change from the original approach so I'm not > familiar with it. I still prefer caching to be implemented and enabled > by default for all servlet factories.
Well, I was just about to check in some changes, but that's not the final word or anything. Really, if caching will be generally implemented I think it still belongs in servlet factories. I think the right way to do that would be to move some of what I've put in PythonServletFactory into ServletFactory, and use a different method in subclasses (something besides servletForTransaction). Maybe something similar to the new PythonServletFactory.loadClass, cleaned up a little. I'll check in a second version that's structured like that. Ian ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ Webware-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/webware-devel
