On Sat, 2004-09-04 at 13:15, Winston WOLFF wrote:
> I have some patches for the PostgreSQL support in MiddleKit.
>I don't
> know what the testing procedure is around here, so I am hesitant to
> check them in actuallly.
Hi Winston,
Thanks for the patches! Generally it's best to post the patches on
the SourceForge project page, to make sure they don't get lost. Also,
please use the unified diff ("diff -u" or "cvs diff -u") when generating
patches; they're easier to read and apply more easily.
I've applied these patches and committed them to CVS.
> Also for the last patch in SQLGenerator.py
> will break support for MySQL and MSSQL, but I don't know enough about
> adding in logic to differentiate it.
I split out the "Connect to database" command into a new method called
writeConnectToDatabase in SQLGenerator.py, so that it can be overridden
in PostgreSQLSQLGenerator.py. This solves the problem for Postgres without
changing behaviour for the other databases. It takes a bit to understand
the use of mixins in MiddleKit so that you know where and how to override
things -- it's unfortunately not immediately obvious how to get stuff done.
I also made a few other PostgreSQL fixes to make the tests pass for MKString
and MKDateTime, and now the test suite produces:
succeeded MKBasic.mkmodel
succeeded MKNone.mkmodel
succeeded MKString.mkmodel
succeeded MKDateTime.mkmodel
*** FAILED *** MKEnums.mkmodel
*** FAILED *** MKDefaultMinMax.mkmodel
succeeded MKTypeValueChecking.mkmodel
succeeded MKInheritance.mkmodel
succeeded MKInheritanceAbstract.mkmodel
succeeded MKList.mkmodel
*** FAILED *** MKObjRef.mkmodel
succeeded MKObjRefReuse.mkmodel
*** FAILED *** MKDelete.mkmodel
*** FAILED *** MKDeleteMark.mkmodel
*** FAILED *** MKMultipleStores.mkmodel
succeeded MKMultipleThreads.mkmodel
succeeded MKModelInh1.mkmodel
succeeded MKModelInh2.mkmodel
succeeded MKModelInh3.mkmodel
skipped MKExcel.mkmodel
--
Jason D. Hildebrand
T: 204 775 1212
E: [EMAIL PROTECTED]
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Webware-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/webware-devel
