Bugs item #1646644, was opened at 2007-01-28 23:46 Message generated for change (Comment added) made by cito You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104866&aid=1646644&group_id=4866
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: WebKit Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Ben Parker (benparker) >Assigned to: Christoph Zwerschke (cito) Summary: cleanStaleSessions loads all sessions into memory Initial Comment: SessionStore's definition of cleanStaleSessions iterates over self.items(), which loads all the sessions into memory. This effectively eliminates the purpose of SessionFileStore. This was repeatedly crashing a Webware process running SessionDynamicStore during periods of peak traffic, when abnormally high numbers of sessions were created. Changing the loop in SessionStore to iterate over the keys, rather than the items, fixes the problem. A patch is attached. ---------------------------------------------------------------------- >Comment By: Christoph Zwerschke (cito) Date: 2007-01-31 00:47 Message: Logged In: YES user_id=193957 Originator: NO You're right, the item() call resulted in all sessions being loaded from the filesystem. Very good fix, thank's a lot. Patched in Rev 6159. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104866&aid=1646644&group_id=4866 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Webware-devel mailing list Webware-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/webware-devel
