URL:
<http://savannah.nongnu.org/bugs/?38321>
Summary: The charset plugin doesn't build on OS X
Project: WeeChat
Submitted by: None
Submitted on: Tue 12 Feb 2013 11:46:09 PM UTC
Category: plugins
Severity: 3 - Normal
Item Group: compile/install
Status: None
Privacy: Public
Assigned to: None
Originator Name: Øyvind Ingebrigtsen Øvergaard
Originator Email: [email protected]
Open/Closed: Open
Discussion Lock: Any
Release: 0.4.0
IRC nick: oyvindio
_______________________________________________________
Details:
The charset plugin is not built on OS X because cmake thinks libiconv isn't
available, which it is (on 10.8.2 at least, it is in /usr/lib).
I was trying to figure this out a while ago, and discovered that swapping the
order of the CHECK_LIBRARY_EXISTS calls in cmake/FindIconv.cmake (oddly)
caused cmake to find libiconv like it should.
I took a closer look at this today, and discovered that if the first
CHECK_LIBRARY_EXISTS call fails, the second call doesn't actually set
ICONV_FOUND to true for some reason (which causes cmake to think that the
library isn't available).
I have attached a patch (fix-libiconv-checks.patch) that resolves this problem
by altering the check logic such that both checks actually matter.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Tue 12 Feb 2013 11:46:09 PM UTC Name: fix-libiconv-checks.patch Size:
912B By: None
<http://savannah.nongnu.org/bugs/download.php?file_id=27455>
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?38321>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
_______________________________________________
Weechat-dev mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/weechat-dev
