On 30 Sep 2011, at 14:47, Stuart Douglas wrote: > > On 30/09/2011, at 11:37 PM, Pete Muir wrote: > >> >> On 30 Sep 2011, at 14:32, Stuart Douglas wrote: >> >>> >>> On 30/09/2011, at 10:43 PM, Pete Muir wrote: >>> >>>> >>>> On 30 Sep 2011, at 13:25, Stuart Douglas wrote: >>>> >>>>> Hi Guys, >>>>> >>>>> I have just gone through and converted to arquillian the last of the >>>>> jboss test harness tests in the weld distribution. Unfortunately it is >>>>> not possible to move all the tests across, as some tests have a >>>>> dependency on the embedded weld container, which is not available in the >>>>> incontainer profile (as the AS7 container is used instead). >>>>> >>>>> With this is mind, I would like to make some changes to the test suite >>>>> setup: >>>>> >>>>> - rename tests-arquillian -> testsuite/integration >>>> >>>> Sounds good. >>>> >>>>> - rename tests -> testsuire/unit >>>> >>>> I would suggest rewriting the tests as proper integration tests. A lot of >>>> this stuff is junk left over from when we were bootstrapping the WebBeans >>>> RI project and didn't have any test harness at all to run with. >>> >>> I am not sure if this is possible, as some of them rely on starting and >>> shutting down the container >>> (org.jboss.weld.tests.unit.cluster.NaiveClusterTest). I know this test has >>> actually picked up problems in the past, so I don't really want to ditch >>> it. >> >> Good point. Can we not move this to weld/core then? > > That might be ok, but it may be a fair bit of code to put in weld core, I > think it would almost amount to moving the are container into weld-core. > > I am probably not going to get time to work on this for the next week or two > anyway, so we have some time to figure it out.
Actually, why not just put the containers into the integration tests module? _______________________________________________ weld-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/weld-dev
