1. JPMS doesn't allow the same package belong to two different modules, in the shaded JAR it contains "javax" and other jboss dependencies.
Well, in shaded JAR, you can actually shade those dependencies, e.g. rename/relocate packages. Though it's optional and I we don't do it at the moment - Martin Kouba now that I think of it, we probably should, WDYT? If we do that, then such shaded JAR could be used even in JDK 9+. The behaviour for JDK 8 users shouldn't change unless they are breaking into our code somehow.
2. It's against the modular system concept to add a shaded jar.
I see what you mean, yet I still disagree as modular system fails address jar versioning in any way and shaded jars are one way to make it work. |