Re: [Wengophone-devel] Patch for flashing in contact lists

Mon, 30 Oct 2006 08:42:25 -0800

You're right, the contact is displayed.
This part of the code is a bit ugly and needs to be refactored.
That's maybe why you don't understand everything :-)

However this patch does not avoid the contact list to flash on our machines. I think more work needs to be done, say a complete refactoring of the contact list display.


Le 30 oct. 06 à 16:30, Lukas Oberhuber a écrit :

Philippe,

 

I just tested adding a contact. The new contact appeared as expected, so I believe the patch is correct.

 

The reason it works is that the new contact is added to the UI in QtContactManager::redrawContacts() which correctly handles the show/hide state. The call in QtContactList was redundant.

 

The main thing that QtContactList does is create the groups (I think). (Unfortunately my understanding of the code is incomplete, so I do have to hunt about for the right place to make the change.)

 

-Lukas

 

Lukas Oberhuber

From: Philippe BERNERY [mailto:[EMAIL PROTECTED]]
Sent: 30 October 2006 12:34
To: Lukas Oberhuber
Cc: [email protected]
Subject: Re: [Wengophone-devel] Patch for flashing in contact lists

 

Hi Lukas,

 

What happened if you add a contact? I think you should not see the newly created contacts with this patch as you removed the QTreeWidget creation.

 

 

Le 30 oct. 06 à 12:37, Lukas Oberhuber a écrit :



I noticed that when I hid unavailable contacts, that I got quite a bit of flashing in the contacts panel, especially when using the asterisk presence management.

 

Here is a patch that fixes this.

 

Basically, QtContactList.cpp should not be managing the UI, but should leave that to QtContactManager.cpp who decides which contacts should be shown.

 

I’ve been testing it for several days and haven’t seen any ill consequences.

 

-Lukas

 

Lukas Oberhuber

 

<QtContactList_flashing.patch>

_______________________________________________

Wengophone-devel mailing list

 



_______________________________________________
Wengophone-devel mailing list
[email protected]
http://dev.openwengo.com/mailman/listinfo/wengophone-devel

Reply via email to