Follow-up Comment #1, patch #1014 (project wesnoth):
I reviewed the patch on coding style here the comment I also left in IRC:
- Try not to make too long lines some people have small terminals and
wrapping lines is annoying to read.
- use ++itor instead of itor++ the former is faster since it doesn't create a
temporary object.
- I agree with Sirp about the compare("foo"), rather use == "foo"
Sirp already said the patch was good enough to commit so somebody will do
that later. (I don't have access to the source atm.)
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1014>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs
