Follow-up Comment #4, patch #1179 (project wesnoth):
Almost there. There are still few issues but the next iteration of the patch
should be suitable for commit. Thanks.
First, the configure code should be organized in a different way. Something
like (pseudo-code):
found_notifications=no
if $with_notifications then
if $with_gtkmm then
PKG_CHECK_MODULES([GTKMM], [gtkmm...], [
PKG_CHECK_MODULES([LIBNOTIFY], [libnoti...], [
CPPFLAGS=...
LIBS=...
found_notifications=yes
AC_DEFINE(...)
], [])
], [])
# notice that the check_modules are nested!
fi
# tests for other notifications systems
fi
AC_MSG_CHECKING([checking for notifications])
AC_MSG_RESULT([$found_notifications])
Second, in game_display.cpp, you are assuming that the icon has been
installed in /use/share/... It may be better to use game_config::path +
"images/wesnoth-icon-small.png" instead.
Third, the code in playmp_controller.cpp is bad from an internationalization
point of view. Strings should never be split in the middle, so that they can
be translated in languages that have sentences the other way around (whatever
that means). You should use something like
utils::interpolate_variables_into_string(_("$name has taken control."),
a_symbol_map_containing_name).
Last, I don't see the "force" parameter being used. If it isn't, please
remove it.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1179>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
