Follow-up Comment #4, patch #1302 (project wesnoth):

Well, I'm not the one who wrote the team coloring script, but anyway, here's
the formulas used in-game:

http://svn.gna.org/viewcvs/wesnoth/trunk/src/color_range.cpp?rev=34695&dir_pagestart=0&view=markup

Yours doesn't do the same. Neither does the current version of course. But if
you feel like it, getting the pixel-by-pixel same results as in-game certainly
would be nice :) Especially the way how a different ratio is used for the
bright case probably looks quite different... still, would have to do the
math or compare screenshots to know for sure.

Also, I wonder if using PIL instead of ImageMagick wouldn't lead to cleaner
code.

In either case, the patch looks fine, I'll apply it once I find time to test
it.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?1302>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to