URL:
<http://gna.org/patch/?3972>
Summary: Fix for bug #20900: Game hangs if bad argument to
--screenshot command line option is provided.
Project: Battle for Wesnoth
Submitted by: dreamer_
Submitted on: Fri Jul 5 04:27:31 2013
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
copy of commit message:
Fix error handling for map loading when --screenshot option
is passed
This is fix for bug #20900: Game hangs if bad argument to
--screenshot command line option is provided.
Bug was caused by exception handling in context_manager::load_map.
When map file failed to load, transient message was requested from
(hidden) gui, which caused gui loop to start.
Fix consists of:
- context_manager::load_map accepts new flag to indicate if it should
run with gui or not
- fix editor::start to properly handle screenshot usecase
- added text logging for (un)successfull screenshot creation
- fix exception unsafe code in editor::start
---
changelog | 2 ++
src/editor/editor_controller.cpp | 3 ++-
src/editor/editor_main.cpp | 51
+++++++++++++++++++++++++++++---------
src/editor/map/context_manager.cpp | 18 ++++++++------
src/editor/map/context_manager.hpp | 3 +--
5 files changed, 55 insertions(+), 22 deletions(-)
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Fri Jul 5 04:27:31 2013 Name:
0001-Fix-error-handling-for-map-loading-when-screenshot-o.patch Size: 8kB
By: dreamer_
<http://gna.org/patch/download.php?file_id=18202>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3972>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
