Update of bug #24569 (project wesnoth):
Category: Bug => Feature Request
Summary: remove readline/history dependency => implement
optional command-line history feature without GNU readline/history dependency
_______________________________________________________
Follow-up Comment #6:
The GnuWin32 project has been shipping readline / history, with msvc
compatibility files, since 2005 according to their news archive:
http://gnuwin32.sourceforge.net/oldnews.html
In 2008 they fixed a bug where some msvc files weren't generated correctly. So
it seems clear that msvc is actively supported.
Regardless of what you think you understand from the documentation, I suggest
that you message them with the problem you are having and see what they
suggest. As shadowm suggested, try contacting upstream before you jump to
conclusions like
> readline is clearly not meant as a platform independent libar
and
> In a plattform indenpendent software like wesnoth, libraries like readline
should never be used.
Again, if readline is "not platform independent", then you seem to know
something that no one else does, and certainly no one at the GnuWin32
project.
Finally, let me point out that readline/history is not in fact a dependency,
it is an optional dependency for an optional feature. One which I created. I
did it this way for several reasons. One of which was to save time rather than
reinvent the wheel, which it certainly did. Second, I was predisposed to use
GNU libraries since wesnoth is GPL anyways, and using other GPL libraries
helps to promote free software.
If you want to create an alternate pathway to implement command line history,
and test it and maintain it indefinitely, by all means, go ahead, as I
originally suggested. In my original email some years ago I wrote "there is
plenty of space between the #else and #endif".
I do not appreciate your classifying an optional dependency for an optional
feature that I made as a bug, or the unsupported claims that the library is
not cross-platform, and that it was a mistake for me to have picked it. I did
not test the feature on windows because I do not use windows, but I did even
test it in mingw / wine, and it worked there. Most wesnoth developers
historically do not test platforms besides their own. Anyways I would be
shocked if the minor issues you raise regarding readline, if they even matter
for wesnoth, cannot be easily worked around.
I have reclassified your report as a feature request, and rewritten the
title.
Please do not "remove readline/history dependency" unless you actually
reimplement and test the features that are supported by it, which I use myself
when I develop addons for the game, having taken the time to implement the
feature myself to much fanfare from the other developers. Otherwise I will
consider your patch to be a bug in return. A compilation option like this does
not harm you at all, so please try to be reasonable.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24569>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs
