adding a border to an image is a one line "convert" command, so I guess
you don't just want a border around images

changing it is a also a one line bash command

Because it should be part of the interface code - the same code that draws the buttons and scrollbars should be able to _optionally_ draw a border around images, and what is most important is that this border is completely variable - that we can change it at any time, to anything. It probably wouldn't be terribly different from the code that draws the edges around our dialog boxes, right now. It would also be, ideally, able to change with whatever theme/skin was being used.

In an operating system UI toolkit, this would usually get called an "image well".

The problem with adding the border via CLI, or anything that actually adds it into the image is that that is destructive editing, which should be avoided like the plague.


OTOH we have little to no image manipulation code ingame for the moment...

I'm not quite sure why you want to add that imgame (by oposition to
adding it to all image via CLI) but I probably miss your point

The thing is - it should not manipulate the image itself - that would invalidate the point of what I'm doing. It should, instead, place this border above, or below (layerwise) the image to be drawn.

Quite similar to a matte for a framed photograph.

bye
Boucman


Richard Kettering a écrit :
Certain of our larger portraits/images have a small, 1px border drawn
around them. This is part of the image file. Examples of where you can
see this include the portraits for HttT and TROW.

I'd like to have this made programmatic, which shouldn't be terribly
difficult. I'd like to have the code apply a border, hopefully rather
similar to the existing one, albeit perhaps somewhat brighter, to any
images flagged in the interface to use that. As a first step, we could probably have a monochromatic border, and if someone wants to get fancy, it shouldn't be hard to cut up images for a patterned one, like what the
current border technically is.


Why?


• Variable image size - this would get applied around any image of any size.

• It can be changed globally.  Doing this would be a hideous waste of
time, under the current system.

• It will make all images follow the convention - currently, quite a
number of our portraits, such as all of the ones submitted by Jason
Lutes, James Woo and Alex-Jarocha Ernst, do not follow the convention.
In fact, the ones that do not follow the convention are a significant
majority, and a good part of those that do are my own, or are images
which I have full-size versions of, without the edge.


--------------------------------------------------------------------- ---

_______________________________________________
Wesnoth-dev mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDwPL6SBeC9Fa95UURApn3AJ9wLlmRQhzz/9BdbBgC3XFzTZZDFwCfWDlD
sba2ULBJFPo5g/hyj3Ddymo=
=9A4Y
-----END PGP SIGNATURE-----


Reply via email to